Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Go runtime to 1.21.3 #1102

Merged
merged 5 commits into from
Oct 24, 2023
Merged

Update Go runtime to 1.21.3 #1102

merged 5 commits into from
Oct 24, 2023

Conversation

jsoriano
Copy link
Member

Update Go runtime to latest 1.21, that includes some fixes in HTTP implementation.

@jsoriano jsoriano requested a review from a team October 24, 2023 09:31
@jsoriano jsoriano self-assigned this Oct 24, 2023
mrodm
mrodm reviewed Oct 24, 2023
View reviewed changes
Copy link
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing to update go.mod with go 1.21.0 and probably update dependencies in go.sum.

@jsoriano
Copy link
Member Author

go.mods updated, as well as the setup in the release pipeline.

mrodm
mrodm approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It looks like there were some leftovers in the second Buildkite pipeline (.buildkite/release-package-registry-distribution.yml). IMO that var for the golang version (SETUP_GOLANG_VERSION) should not be needed

.buildkite/release-package-registry-distribution.yml Outdated Show resolved Hide resolved
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @jsoriano

@jsoriano jsoriano merged commit 1607548 into elastic:main Oct 24, 2023
1 check passed
@jsoriano jsoriano deleted the go-1.21.3 branch October 24, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrodm mrodm mrodm approved these changes

Assignees

@jsoriano jsoriano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsoriano @elasticmachine @mrodm