Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cloudsecurity_cdr category #1142

Merged
merged 3 commits into from
Feb 19, 2024
Merged

add cloudsecurity_cdr category #1142

merged 3 commits into from
Feb 19, 2024

Conversation

CohenIdo
Copy link
Contributor

@jsoriano jsoriano self-requested a review February 15, 2024 11:26
jsoriano
jsoriano reviewed Feb 15, 2024
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for confirmation from product.

categories/categories.yml Outdated
Comment on lines 116 to 117
cloudsecurity_cdr:
title: "CDR"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nimarezainia are we ok with adding this category as a subcategory of security category?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@CohenIdo
Copy link
Contributor Author

CohenIdo commented Feb 15, 2024 •
edited
Loading

LGTM, waiting for confirmation from product.

cc: @snehsach19

@CohenIdo CohenIdo requested a review from jsoriano February 15, 2024 13:33
@elasticmachine
Copy link

💚 Build Succeeded

History

@CohenIdo CohenIdo merged commit b6e0e6e into elastic:main Feb 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snehsach19 snehsach19 snehsach19 left review comments

@nimarezainia nimarezainia nimarezainia approved these changes

@jsoriano jsoriano Awaiting requested review from jsoriano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CohenIdo @elasticmachine @jsoriano @nimarezainia @snehsach19