-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go runtime to 1.23.2 #1242
Conversation
go.mod
Outdated
@@ -1,8 +1,8 @@ | |||
module github.com/elastic/package-registry | |||
|
|||
go 1.22.1 | |||
go 1.22.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated also to the latest Golang 1.22 version.
Not sure if this is required, since the version defined in the toolchain is going to be downloaded and used.
WDYT ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would keep it as 1.22.1 if possible. This will be the minimum version required for projects importing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok! Reverting it.
@@ -1 +1 @@ | |||
1.23.1 | |||
1.23.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better to set here the same as in the go.mod (go directive) 1.22.8?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the version used for building, right? I would use the latest one here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly, this is going to be used in CI and also following the indications of the README to build the package-registry binary too: https://github.com/elastic/package-registry?tab=readme-ov-file#go-command
💚 Build Succeeded
History
cc @mrodm |
Updated to the latest version of Golang 1.23