Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go runtime to 1.23.2 #1242

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Update go runtime to 1.23.2 #1242

merged 3 commits into from
Oct 28, 2024

Conversation

mrodm
Copy link
Contributor

@mrodm mrodm commented Oct 25, 2024

Updated to the latest version of Golang 1.23

go.mod Outdated
@@ -1,8 +1,8 @@
module github.com/elastic/package-registry

go 1.22.1
go 1.22.8
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated also to the latest Golang 1.22 version.

Not sure if this is required, since the version defined in the toolchain is going to be downloaded and used.

WDYT ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep it as 1.22.1 if possible. This will be the minimum version required for projects importing this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! Reverting it.

@@ -1 +1 @@
1.23.1
1.23.2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to set here the same as in the go.mod (go directive) 1.22.8?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the version used for building, right? I would use the latest one here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly, this is going to be used in CI and also following the indications of the README to build the package-registry binary too: https://github.com/elastic/package-registry?tab=readme-ov-file#go-command

@mrodm mrodm self-assigned this Oct 25, 2024
@mrodm mrodm marked this pull request as ready for review October 25, 2024 11:27
@mrodm mrodm requested a review from a team October 25, 2024 11:27
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @mrodm

@mrodm mrodm merged commit 4508d72 into elastic:main Oct 28, 2024
5 checks passed
@mrodm mrodm deleted the update-go.1.23.2 branch October 28, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants