Generate index.json #470
Generate index.json #470
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
|
index.go
Outdated
| func indexHandler(cacheTime time.Duration) (func(w http.ResponseWriter, r *http.Request), error) { | ||
| data := indexData{ | ||
| ServiceName: "package-registry", | ||
| Version: "0.4.0", |
There was a problem hiding this comment.
Nit: Could have this as a constant in the main.go file?
index.go
Outdated
|
|
||
| func indexHandler(cacheTime time.Duration) (func(w http.ResponseWriter, r *http.Request), error) { | ||
| data := indexData{ | ||
| ServiceName: "package-registry", |
There was a problem hiding this comment.
Nit: Could we have this as a constant?
Yup, already added. |
There was a problem hiding this comment.
I'm happy there is now a single source of truth for this information.
I would prefer to keep it in index.json so other tools can read it from the filesystem. This approach requires an HTTP request if I understand correctly.
Not hard to change later if we want, though. Thanks for cleaning this up.
| router.HandleFunc("/search", searchHandler(packagesBasePath, config.CacheTimeSearch)) | ||
| router.HandleFunc("/categories", categoriesHandler(packagesBasePath, config.CacheTimeCategories)) | ||
| router.HandleFunc("/health", healthHandler) | ||
| router.HandleFunc("/favicon.ico", faviconHandleFunc) | ||
| router.PathPrefix("/").HandlerFunc(catchAll(http.Dir(config.PublicDir), config.CacheTimeCatchAll)) | ||
| router.PathPrefix("/epr").HandlerFunc(catchAll(http.Dir(config.PublicDir), config.CacheTimeCatchAll)) |
There was a problem hiding this comment.
@mtojtek are the /epr and /package routes new?
There was a problem hiding this comment.
From the user perspective - no, they're already exposed.
Speaking about the implementation, this has been already adjusted (see the master branch). Archives exposed via the /epr endpoint are built dynamically, not served from the file system.
This PR is only for the main |
Yes, that was my understanding. I'll try to keep an eye out, but can you add me on that PR when you submit it? Thanks |
Issue: #469
Let's first merge this PR: #468