Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update registry for stream.* to dataset.* change #492

Merged
merged 3 commits into from
Jun 8, 2020

Conversation

ruflin
Copy link
Contributor

@ruflin ruflin commented Jun 3, 2020

Now the dataset intsead of the stream fields are added and validated.

Updating also the base package. This will have to be pushed to the package-storage.

Part of #491

@ruflin ruflin requested a review from mtojek June 3, 2020 11:18
@ruflin ruflin self-assigned this Jun 3, 2020
@elasticmachine
Copy link

elasticmachine commented Jun 3, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Started by user Nicolas Ruflin, Replayed #12]

  • Start Time: 2020-06-08T14:11:03.283+0000

  • Duration: 5 min 33 sec

ruflin added 3 commits June 8, 2020 14:26
Now the dataset intsead of the stream fields are added and validated.

Updating also the base package. This will have to be pushed to the package-storage.

Part of elastic#491
Copy link
Contributor Author

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mtojek are you ok with getting this in?

Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, based on the fact that there are changes for integrations ready in elastic/integrations#64

@ruflin ruflin merged commit 955239d into elastic:master Jun 8, 2020
@ruflin ruflin deleted the dataset-changes branch June 8, 2020 17:43
ruflin pushed a commit to elastic/kibana that referenced this pull request Jun 9, 2020
Resolves #67672

Part of elastic/package-registry#491

See elastic/package-registry#492 for package registry changes.

Updates existing queries to use `dataset.*` fields. from `stream.*` fields.

I looked at the EPM code paths for asset installation, and did not find anything that would need to be changed based on the above package registry changes. We don't hardcode anything specific for field names. The package information (i.e. [nginx package info](https://epr.elastic.co/package/nginx/0.1.2/)) is not affected by the current package registry changes.
jen-huang added a commit to jen-huang/kibana that referenced this pull request Jun 9, 2020
…ic#68322)

Resolves elastic#67672

Part of elastic/package-registry#491

See elastic/package-registry#492 for package registry changes.

Updates existing queries to use `dataset.*` fields. from `stream.*` fields.

I looked at the EPM code paths for asset installation, and did not find anything that would need to be changed based on the above package registry changes. We don't hardcode anything specific for field names. The package information (i.e. [nginx package info](https://epr.elastic.co/package/nginx/0.1.2/)) is not affected by the current package registry changes.
jen-huang added a commit to elastic/kibana that referenced this pull request Jun 9, 2020
… (#68667)

Resolves #67672

Part of elastic/package-registry#491

See elastic/package-registry#492 for package registry changes.

Updates existing queries to use `dataset.*` fields. from `stream.*` fields.

I looked at the EPM code paths for asset installation, and did not find anything that would need to be changed based on the above package registry changes. We don't hardcode anything specific for field names. The package information (i.e. [nginx package info](https://epr.elastic.co/package/nginx/0.1.2/)) is not affected by the current package registry changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants