Add -dry-run flag to registry #503
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
|
| @@ -33,6 +33,7 @@ const ( | |||
| var ( | |||
| packagesBasePath string | |||
| address string | |||
| dryRun bool | |||
There was a problem hiding this comment.
Dry run term might be confusing in terms of a web service (what is a registry doing if it's not playing a role of a web service).
The real function you've enabled here is package validation. What do you think about splitting code into phases (representing states): e.g. validation, running? If the service didn't start, you would know which phase did it fail.
There was a problem hiding this comment.
If we go the above route, how would the integration test then look like?
There was a problem hiding this comment.
Building packages can be considered as @BeforeClass (a requirement for test) :) Let's say we have two test cases:
TestValidation:
Cmd args: "-state=validation"
Expected: app exits with code 0, message: VALIDATION OK or VALIDATION FAILED: Message why did it fail
TestRunning (without validation):
Cmd args: "-state=running"
Expected: process is running, web server exposed on port A
TestDefault (so including validation):
Cmd args: (none)
Expected: process is running, web server exposed on port A
My point is to enable testing on multiple levels the process startup. I'm not insisting on this change if you think this in an overkill here. I'm not convinced to applying the term "dry-run" to a web service.
There was a problem hiding this comment.
I see where you are going here but not sure we need this at the moment. Also not too happy with the naming of the flag. Any alternative suggestion?
There was a problem hiding this comment.
I think it's all about the name of the flag right now, so if we can't find a best option for both of us, let's keep it as is ;)
There was a problem hiding this comment.
Haha, naming. I'll add a note that the flag is experimental and might be removed at any time.
The -dry-run flag allows to run the registry without starting the service. This has the nice benefit that the registry itself can be started to validate all the packages and directly checking the output for errors. A test to the integration tests was added to use this behaviour.
The -dry-run flag allows to run the registry without starting the service. This has the nice benefit that the registry itself can be started to validate all the packages and directly checking the output for errors.
A test to the integration tests was added to use this behaviour.