Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove solution entry in package manifest #504

Merged
merged 2 commits into from
Jun 11, 2020

Conversation

ruflin
Copy link
Contributor

@ruflin ruflin commented Jun 10, 2020

Based on the discussion in elastic/kibana#67939 it seems like we do not need the solution entry in the manifest. This removes it.

ruflin added 2 commits June 10, 2020 11:36
Based on the discussion in elastic/kibana#67939 it seems like we do not need the solution entry in the manifest. This removes it.
@ruflin
Copy link
Contributor Author

ruflin commented Jun 10, 2020

@jonathan-buttner FYI as it should also be removed from the endpoint package I think if we move forward with this.

@elasticmachine
Copy link

elasticmachine commented Jun 10, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Branch indexing]

  • Start Time: 2020-06-11T12:18:31.066+0000

  • Duration: 9 min 55 sec

@jonathan-buttner
Copy link
Contributor

Thanks for the heads up. It's not going to cause issues having that field in the manifest though right? is it acceptable to only remove it from future package releases?

@jen-huang
Copy link
Contributor

It's not going to cause issues having that field in the manifest though right?

It's not an issue on Kibana side as we don't attempt to read that field.

@ruflin
Copy link
Contributor Author

ruflin commented Jun 11, 2020

@jonathan-buttner Yes, we only validate fields we know about and ignore everything else.

@ruflin ruflin merged commit d4a6d00 into elastic:master Jun 11, 2020
@ruflin ruflin deleted the remove-solution branch June 11, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants