Do not require config.yml #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
|
ruflin
reviewed
Jun 15, 2020
| @@ -114,16 +116,18 @@ func main() { | |||
|
|
|||
| func getConfig() (*Config, error) { | |||
| cfg, err := ucfgYAML.NewConfigWithFile(configPath) | |||
| if os.IsNotExist(err) { | |||
| return &defaultConfig, nil | |||
There was a problem hiding this comment.
Could you add a log message here that the default configs are used as no config was found?
config.yml
Outdated
| @@ -1,5 +0,0 @@ | |||
| public_dir: "./public" | |||
There was a problem hiding this comment.
I would still like to keep this one to show users what configs are there. It is also part documentation.
There was a problem hiding this comment.
How about config.reference.yml?
There was a problem hiding this comment.
++. Should we fall back to it or just have it there?
There was a problem hiding this comment.
There won't be any config.yml by default as it's not required, but there is will be a config.reference.yml if users would like to preview the configuration file.
ruflin
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: