Rename kibana query param to kibana.version
#518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `/search` query param was renamed from `kibana` to `kibana.version`. There are two reasons for this. The first one is to align the naming inside requirements in the manifest with the actual query param. The second is to make sure in case we have other criterias related to kibana in the future, there is space for this. As Kibana does not use this query today, this should not affect any parts yet. More changes: * Cleaned up some duplicated if clauses spotted during an other PR review
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
mtojek
approved these changes
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
/searchquery param was renamed fromkibanatokibana.version. There are two reasons for this. The first one is to align the naming inside requirements in the manifest with the actual query param. The second is to make sure in case we have other criterias related to kibana in the future, there is space for this.As Kibana does not use this query today, this should not affect any parts yet.
More changes: