Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce development mode #543

Merged
merged 3 commits into from
Jun 24, 2020
Merged

Introduce development mode #543

merged 3 commits into from
Jun 24, 2020

Conversation

mtojek
Copy link
Contributor

@mtojek mtojek commented Jun 24, 2020

This PR introduce development mode. In this mode all package content is not served from memory cache.

@mtojek mtojek requested a review from ruflin June 24, 2020 06:36
@mtojek mtojek self-assigned this Jun 24, 2020
@mtojek mtojek mentioned this pull request Jun 24, 2020
Merged
ruflin
ruflin approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, changelog?

I wonder if we should set all CacheTime* variables to 0 if DevMode is enabled?

@elasticmachine
Copy link

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #543 opened]

  • Start Time: 2020-06-24T06:36:59.127+0000

  • Duration: 9 min 39 sec

Test stats 🧪

Test Results
Failed 0
Passed 127
Skipped 0
Total 127

@mtojek
Copy link
Contributor Author

mtojek commented Jun 24, 2020

I wonder if we should set all CacheTime* variables to 0 if DevMode is enabled?

Not sure if it would be the expected outcome - ignore all CacheTime options in the configuration file, because the DevMode is enabled.

@mtojek mtojek merged commit 4bf148f into elastic:master Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtojek @elasticmachine @ruflin