Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename datasources to config_templates #570

Merged
merged 3 commits into from
Jun 30, 2020

Conversation

ruflin
Copy link
Contributor

@ruflin ruflin commented Jun 30, 2020

A previous PR renamed it to config_templates in the json output and Kibana was adjusted. This now adjusts it also on the input side. The package-storage and integrations repository also need to be updated.

A previous PR renamed it to config_templates in the json output and Kibana was adjusted. This now adjusts it also on the input side. The package-storage and integrations repository also need to be updated.
@ruflin ruflin self-assigned this Jun 30, 2020
@elasticmachine
Copy link

elasticmachine commented Jun 30, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #570 updated]

  • Start Time: 2020-06-30T07:27:15.231+0000

  • Duration: 9 min 46 sec

Test stats 🧪

Test Results
Failed 0
Passed 143
Skipped 0
Total 143

@ruflin
Copy link
Contributor Author

ruflin commented Jun 30, 2020

@jonathan-buttner You also need to be aware of this change.

ruflin added a commit to ruflin/package-storage that referenced this pull request Jun 30, 2020
As soon as elastic/package-registry#570 is merged, the registry version must be updated.
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the notification email. Just small bug here.

util/package.go Outdated Show resolved Hide resolved
@ruflin ruflin requested a review from mtojek June 30, 2020 07:38
@ruflin ruflin merged commit f91d80e into elastic:master Jun 30, 2020
ruflin added a commit to elastic/package-storage that referenced this pull request Jun 30, 2020
As soon as elastic/package-registry#570 is merged, the registry version must be updated.
@jonathan-buttner
Copy link
Contributor

@jonathan-buttner You also need to be aware of this change.

Thanks I updated our repo 👍

@ruflin ruflin deleted the config_templates branch June 30, 2020 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants