Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for logs/metrics categories #571

Merged
merged 5 commits into from
Jun 30, 2020

Conversation

ruflin
Copy link
Contributor

@ruflin ruflin commented Jun 30, 2020

The metrics and logs categories are not supported anymore. This removes support for it. But it can only be merged after elastic/package-storage#97 landed.

@ruflin ruflin self-assigned this Jun 30, 2020
@elasticmachine
Copy link

elasticmachine commented Jun 30, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #571 updated]

  • Start Time: 2020-06-30T18:00:59.853+0000

  • Duration: 9 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 143
Skipped 0
Total 143

ruflin added 3 commits June 30, 2020 16:00
The metrics and logs categories are not supported anymore. This removes support for it. But it can only be merged after elastic/package-storage#97 landed.
@ruflin ruflin force-pushed the remove-legacy-categories branch from 4417e28 to 6989889 Compare June 30, 2020 14:06
@ruflin ruflin marked this pull request as ready for review June 30, 2020 14:06
@ruflin ruflin requested a review from mtojek June 30, 2020 14:07
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity: is the list of categories noted somewhere publicly? for development purposes

@ruflin
Copy link
Contributor Author

ruflin commented Jun 30, 2020

@mtojek Yes, the categories are available here: https://github.com/elastic/package-registry/blob/master/util/package.go#L23

@ruflin ruflin merged commit 7d56b1c into elastic:master Jun 30, 2020
@ruflin ruflin deleted the remove-legacy-categories branch June 30, 2020 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants