Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove public_dir config #632

Merged
merged 3 commits into from
Sep 7, 2020
Merged

Remove public_dir config #632

merged 3 commits into from
Sep 7, 2020

Conversation

ruflin
Copy link
Contributor

@ruflin ruflin commented Sep 2, 2020

This config is replaced by package_paths and not needed anymore.

@ruflin ruflin requested a review from mtojek September 2, 2020 07:24
@ruflin ruflin self-assigned this Sep 2, 2020
@ruflin
Copy link
Contributor Author

ruflin commented Sep 2, 2020

@mtojek Do we still use this somewhere?

@elasticmachine
Copy link

elasticmachine commented Sep 2, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #632 updated]

  • Start Time: 2020-09-07T11:33:02.671+0000

  • Duration: 8 min 6 sec

Test stats 🧪

Test Results
Failed 0
Passed 161
Skipped 0
Total 161

@ruflin
Remove public_dir config
25fc9ca 
This config is replaced by package_paths and not needed anymore.
@ruflin
update changelog
1429959
@ruflin ruflin merged commit 509d0db into elastic:master Sep 7, 2020
@ruflin ruflin deleted the remove-public-dir branch September 7, 2020 12:19
@ycombinator ycombinator mentioned this pull request Sep 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtojek mtojek mtojek approved these changes

Assignees

@ruflin ruflin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruflin @elasticmachine @mtojek