Set cache headers for 404 and 400 to 0 #649
Conversation
Fastly caches 404 headers by default. This could cause issues when rolling out a new registry and a path was requested to early. This sets the cache time to 0. Fastly docs: https://docs.fastly.com/en/guides/http-status-codes-cached-by-default
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
handler.go
Outdated
| @@ -17,10 +17,12 @@ import ( | |||
| var errResourceNotFound = errors.New("resource not found") | |||
|
|
|||
| func notFoundError(w http.ResponseWriter, err error) { | |||
| cacheHeaders(w, 0) | |||
There was a problem hiding this comment.
I think you need to change the internal implementation. The recommended for Cache-Control value for not cachable resources is:
Cache-Control: no-cache, no-store, must-revalidate
see: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control (Preventing caching)
There was a problem hiding this comment.
WDYT about using "private"? https://docs.fastly.com/en/guides/configuring-caching#do-not-cache
There was a problem hiding this comment.
Hm.. "private" is to inform the intermittent servers not to cache data, because they will be cached by browsers. To prevent caching on the browser level, AFAIK you need to add Max-Age: 0.
There was a problem hiding this comment.
Referring to the Mozilla docs, Cache-Control: no-store should be sufficient at this point:
no-store
The response may not be stored in any cache. Although other directives may be set, this alone is the only directive you need in preventing cached responses on modern browsers. max-age=0 is already implied. Setting must-revalidate does not make sense because in order to go through revalidation you need the response to be stored in a cache, which no-store prevents.
There was a problem hiding this comment.
Fastly does not respect no-store:
Fastly does not currently respect no-store or no-cache directives. Including either or both of these in a Cache-Control header has no effect on Fastly's caching decision, unless you alter this behavior using custom VCL.
|
This now sets This should work for browser and especially Fastly too. |
Fastly caches 404 headers by default. This could cause issues when rolling out a new registry and a path was requested to early. This sets the cache time to 0.
Fastly docs: https://docs.fastly.com/en/guides/http-status-codes-cached-by-default