Add APM instrumentation #702
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
jsoriano
force-pushed
the
apm-instrumentation
branch
from
079049f to
b2de498
Compare
categories.go
Outdated
| } | ||
|
|
||
| func (filter categoriesFilter) Filter(ctx context.Context, packages util.Packages) map[string]util.Package { | ||
| span, _ := apm.StartSpan(ctx, "FilterPackages", "custom") |
There was a problem hiding this comment.
I would suggest changing all the span types from "custom" to "app". This should work better with the "time spent by span type" chart in APM:
Transaction time is countered under "app", and if you add spans with type "app" then they will add to this. i.e. it's best practice (probably not written down anywhere) to use "app" for spans related to application code.
There was a problem hiding this comment.
Changed 👍
Btw, when initializing the service (here), I am using "backend.init" as transaction type, is this ok?
Are there some guidelines or list of recommended values for transaction and span types?
There was a problem hiding this comment.
That is okay, and I don't think it particularly matters. HTTP requests will be given the transaction type "request". I'm not aware of any guidance for transaction types for this kind of program initialisation.
Yes, next step would be to see where we send the data, and configure the registries used in production. |
In #670 we are planning to introduce some refactors, in part motivated by performance issues. Introduce some instrumentation to evaluate what parts of the service require more performance tunning. And in the future to be able to compare the impact of the applied changes.
With this instrumentation we can collect traces such as this one:
Checklist:
/categories, tests failing.