Adjust counting logic for categories/policy templates #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
jsoriano
approved these changes
Sep 8, 2021
| package util | ||
|
|
||
| // StringsContains function checks if needle is present in the stack. | ||
| func StringsContains(haystack []string, needle string) bool { |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #714
This PR corrects following issues:
/categoriescounts policies and packages separatedly as now, but packages are counted too if they don't match but any of their policies does (for the AWS case this would mean that the count for datastore would be 3: the package and the rds and dynamodb policies, it is 2 now)./searchreturns packages with their policies filtered out (for AWS it would return a package with just 2 policies, what would match the count of 3).