Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-dot 'kibana.version' in /package JSON responses #733

Merged
merged 2 commits into from
Sep 29, 2021

Conversation

andrewkroh
Copy link
Member

This changes the response JSON from

  "conditions": {
    "kibana.version": "^7.15.0"
  },

to

  "conditions": {
    "kibana": {
      "version": "^7.15.0"
    }
  },

Closes #730

@elasticmachine
Copy link

elasticmachine commented Sep 22, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-29T21:16:50.305+0000

  • Duration: 6 min 32 sec

  • Commit: d2d233f

Test stats 🧪

Test Results
Failed 0
Passed 95
Skipped 0
Total 95

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@andrewkroh andrewkroh force-pushed the bugfix/de-dot-kibana-version branch from 3bf1570 to ed09685 Compare September 22, 2021 22:32
This changes the response JSON from

```
  "conditions": {
    "kibana.version": "^7.15.0"
  },
```

to

```
  "conditions": {
    "kibana": {
      "version": "^7.15.0"
    }
  },
```

Closes elastic#730
@andrewkroh andrewkroh force-pushed the bugfix/de-dot-kibana-version branch from ed09685 to a879121 Compare September 22, 2021 22:35
@andrewkroh andrewkroh changed the title De-dot 'kibana.version' is /package JSON responses De-dot 'kibana.version' in /package JSON responses Sep 22, 2021
@mtojek mtojek requested review from ruflin and mtojek September 23, 2021 08:08
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it doesn't mean that we break the API or just ... unwrap keys :) @ruflin WDYT ?

@ruflin
Copy link
Contributor

ruflin commented Sep 23, 2021

This might break Fleet. @joshdover @jen-huang Lets make sure the team reviews / tests this before it gets in.

Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally and did not see any breaking changes in Fleet, in fact we already had the de-dotted version typed:
https://github.com/elastic/kibana/blob/3eb93a84f52e1c884de06ce089fcd6f1dbbf23fa/x-pack/plugins/fleet/common/types/models/package_spec.ts#L54

I also tested the search endpoint that Fleet uses to query for packages which are compatible, i.e. /search?experimental=true&kibana.version=7.14.1 and that worked as expected too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON responses contain key with dot in 'kibana.version'
5 participants