-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Add categories to search response output #735
[Fleet] Add categories to search response output #735
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Let's make sure if it works correctly for all our use cases.
- Please run
make format
mage format
to clean this code. - Please add a changelog entry to the
CHANGELOG.md
. - Please run
go test .
to see if something has changed (-generate
to regenerate golden files).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I double-checked it against the policy template case (url: /search?category=datastore&experimental=true
) and it seems to be correct: https://github.com/elastic/package-registry/blob/d2bbfb6efbca8c93d0c9195c871d40450817fae0/testdata/generated/search-category-datastore.json
I think you're good to go, Thomas. You can proceed with releasing procedure. If you encounter any blockers, we can help you with them. FYI release cycles of EPR are detached from Elastic release trains, so feel free to do this anytime.
Closes #722
This adds the categories to the search-response output.
cc @joshdover