Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with relative paths when loading data streams #742

Merged
merged 3 commits into from
Oct 11, 2021

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Oct 7, 2021

Relative paths calculation for data streams depends on the paths
having trailing separators or not. Use filepath.Rel to obtain these
relative paths.

@jsoriano jsoriano added the Team:Ecosystem Label for the Packages Ecosystem team label Oct 7, 2021
@jsoriano jsoriano requested a review from mtojek October 7, 2021 15:26
@jsoriano jsoriano self-assigned this Oct 7, 2021
@elasticmachine
Copy link

elasticmachine commented Oct 7, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-11T11:29:33.146+0000

  • Duration: 5 min 35 sec

  • Commit: d3341a1

Test stats 🧪

Test Results
Failed 0
Passed 114
Skipped 0
Total 114

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

packages/fs.go Outdated Show resolved Hide resolved
packages/package.go Outdated Show resolved Hide resolved
@mtojek mtojek self-requested a review October 11, 2021 12:59
@jsoriano jsoriano merged commit a6e358f into elastic:master Oct 11, 2021
@jsoriano jsoriano deleted the data-stream-relative-paths branch October 11, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Ecosystem Label for the Packages Ecosystem team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants