Prepare stub for Storage Indexer #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
added 2 commits
May 12, 2022 14:05
jsoriano
approved these changes
May 18, 2022
main.go
Outdated
Comment on lines
133
to
137
| indexers = append(indexers, packages.NewFileSystemIndexer(packagesBasePaths...)) | ||
| indexers = append(indexers, packages.NewZipFileSystemIndexer(packagesBasePaths...)) | ||
| if featureStorageIndexer { | ||
| indexers = append(indexers, storage.NewIndexer()) | ||
| } |
There was a problem hiding this comment.
Do we want both indexers at the same time? I think it'd be ok to use only the storage indexer when the flag is used.
Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #767
This PR introduces a stub for the future v2 Storage Indexer. It removes the logic responsible for pulling packages from Package Storage v1.
Comment:
I'd rather publish a set of smaller PRs instead of a huge one with the entire implementation.