Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support zip files without directory entries #817

Merged
merged 2 commits into from
May 31, 2022

Conversation

jsoriano
Copy link
Member

Some filesystems, as some zip files, can lack of entries for directories.
When looking for files, don't rely on directories.

Fixes #816.

@jsoriano jsoriano requested a review from a team May 31, 2022 15:14
@jsoriano jsoriano self-assigned this May 31, 2022
@elasticmachine
Copy link

elasticmachine commented May 31, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-31T16:19:33.175+0000

  • Duration: 5 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 154
Skipped 0
Total 154

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

EDIT:

Does it need a changelog entry as it's a bugfix?

@jsoriano
Copy link
Member Author

Does it need a changelog entry as it's a bugfix?

Good point, changelog added.

@jsoriano jsoriano merged commit dc2c05d into elastic:main May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fs.Glob skips directories while using .zip file system
3 participants