Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill deprecated license field with the value of the new subscription condition #826

Merged
merged 5 commits into from
Jul 19, 2022

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Jun 30, 2022

Alternative to #825, that only adds a compatibility layer from the old to the new field.

@jsoriano jsoriano self-assigned this Jun 30, 2022
@jsoriano jsoriano marked this pull request as ready for review June 30, 2022 15:42
@jsoriano jsoriano requested a review from a team June 30, 2022 15:42
@elasticmachine
Copy link

elasticmachine commented Jun 30, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-18T14:23:07.549+0000

  • Duration: 5 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 207
Skipped 0
Total 207

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@mtojek
Copy link
Contributor

mtojek commented Jul 4, 2022

/test

Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that you have to update golden files.

@jsoriano jsoriano requested a review from mtojek July 18, 2022 10:13
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the next step, you can adjust the elastic-package create to handle it correctly.

BTW Does it need a changelog entry?

@jsoriano
Copy link
Member Author

Changelog added.

@mtojek mtojek self-requested a review July 19, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants