dockerfile: replace mime-support with media-types #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
mailcap was added back when the image was using centOS to add /etc/mime.types. See elastic#599 Later, the package registry moved to Ubuntu LTS and mailcap was replaced by mime-support which also installs mailcap. Now mime-support is a transitional package and we can replace it with media-types, to only install the file (/etc/mime.types) that we need. The issue with mailcap is the large dependency tree and the dependency on perl, by replacing mime-support with media-types we can reduce the image size. Before: 202MB After: 148MB
kruskall
changed the title
kruskall
force-pushed
the
fix/replace-mime-support
branch
from
156578e to
8debc16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mailcap was added back when the image was using centOS to add
/etc/mime.types.
See #599
Later, the package registry moved to Ubuntu LTS and mailcap was
replaced by mime-support which also installs mailcap.
Now mime-support is a transitional package and we can replace it with
media-types, to only install the file (/etc/mime.types) that we need.
The issue with mailcap is the large dependency tree and the dependency
on perl, by replacing mime-support with media-types we can reduce the
image size.
Before: 202MB
After: 148MB