Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate if field groups don't have units and metric types defined #183

Merged
merged 4 commits into from
Jun 9, 2021

Conversation

mtojek
Copy link
Contributor

@mtojek mtojek commented Jun 8, 2021

What does this PR do?

This PR introduces another semantic validation check to verify if field groups don't use units and metric types.

Why is it important?

Field groups shouldn't use units and metric types.

Checklist

Related issues

@mtojek mtojek self-assigned this Jun 8, 2021
@mtojek mtojek requested a review from ruflin June 8, 2021 09:49
@elasticmachine
Copy link

elasticmachine commented Jun 8, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #183 updated

  • Start Time: 2021-06-08T10:10:22.310+0000

  • Duration: 2 min 13 sec

  • Commit: eab7a55

Trends 🧪

Image of Build Times

@mtojek
Copy link
Contributor Author

mtojek commented Jun 8, 2021

Ouch, forgot about metric_type. Let me fix the PR.

@mtojek mtojek changed the title Validate if field groups don't have units defined Validate if field groups don't have units and metric types defined Jun 8, 2021
Copy link

@fearful-symmetry fearful-symmetry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not 100% familiar with the package-spec, but otherwise LGTM.

@mtojek mtojek merged commit 13dfeba into elastic:master Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants