-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stricter validation of field definitions #420
Conversation
🌐 Coverage report
|
Tested with integrations and some adjustments done. I think that the number of changes required on existing integrations now are reasonable. |
additionalProperties: true | ||
additionalProperties: false | ||
patternProperties: | ||
# Soft validation on some properties that can be present but not validated or used yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main reason I am leaving it here is to reduce the number of changes that package developers should make to migrate to v2, and to avoid conflicts with fields copied from ECS or Beats. But these fields are not really used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, if it is not required too many changed done by developer to migrate, it will be easier that packages get updated to 2.0.0 👍
Those could be removed in a following major if it is required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What does this PR do?
Stricter validation of field definitions.
Why is it important?
To reduce the risk of typos in field definitions that can lead to unexpected mappings.
Checklist
test/packages
that prove my change is effective.spec/changelog.yml
.Related issues