Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert suppression options for missing suppression fields #3205

Merged
merged 9 commits into from
May 17, 2023

Conversation

joepeeples
Copy link
Contributor

@joepeeples joepeeples commented Apr 28, 2023

@github-actions
Copy link

Documentation previews:

@joepeeples joepeeples marked this pull request as ready for review May 11, 2023 14:53
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left a few suggestions for your consideration

docs/detections/alert-suppression.asciidoc Outdated Show resolved Hide resolved
docs/detections/alert-suppression.asciidoc Outdated Show resolved Hide resolved
docs/detections/alert-suppression.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left a few suggestions for your consideration

Copy link
Contributor

@vitaliidm vitaliidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you apply this small change you suggested, this'll be good to merge. Thanks!

docs/detections/alert-suppression.asciidoc Outdated Show resolved Hide resolved
@joepeeples joepeeples merged commit f4932b5 into main May 17, 2023
mergify bot pushed a commit that referenced this pull request May 17, 2023
* First (incomplete) draft

* tiny edit

* Update with latest UI text

* Update screenshot

* Apply suggestions from Ben's review

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

* Apply suggestions from code review

---------

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
(cherry picked from commit f4932b5)
@joepeeples joepeeples deleted the 3191-alert-suppression-empty-fields branch May 17, 2023 13:33
joepeeples added a commit that referenced this pull request May 17, 2023
* First (incomplete) draft

* tiny edit

* Update with latest UI text

* Update screenshot

* Apply suggestions from Ben's review

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

* Apply suggestions from code review

---------

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
(cherry picked from commit f4932b5)

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
@joepeeples joepeeples mentioned this pull request May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alert suppression options for missing suppression fields
4 participants