Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Case file attachments #3236

Merged
merged 3 commits into from
May 9, 2023
Merged

[DOCS] Case file attachments #3236

merged 3 commits into from
May 9, 2023

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented May 5, 2023

Relates to #3171, elastic/kibana#154881

This PR adds an "Add files" section to https://www.elastic.co/guide/en/security/master/cases-open-manage.html

It also updates the existing screenshots to reflect the new "Files" tab.

@github-actions
Copy link

github-actions bot commented May 5, 2023

Documentation previews:

@lcawl lcawl mentioned this pull request May 5, 2023
Closed
6 tasks
@lcawl lcawl marked this pull request as ready for review May 5, 2023 18:19
@lcawl lcawl requested a review from nastasha-solomon May 5, 2023 18:19
@nastasha-solomon nastasha-solomon mentioned this pull request May 7, 2023
Closed
19 tasks
nastasha-solomon
nastasha-solomon approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these updates, @lcawl! In addition the minor edit I suggested, I was wondering if it'd make sense to add to the third bullet here, there users can also examine files attached to the case.

docs/cases/cases-manage.asciidoc Outdated Show resolved Hide resolved
lcawl and others added 2 commits May 8, 2023 11:33
@lcawl @nastasha-solomon
Apply suggestions from code review
06969c8 
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
@lcawl
[DOCS] Add link to subsection
0648b70
@lcawl
Copy link
Contributor Author

lcawl commented May 8, 2023

... I was wondering if it'd make sense to add to the third bullet here, there users can also examine files attached to the case.

Good catch! I've added 0648b70

@lcawl lcawl merged commit 49ac99b into elastic:main May 9, 2023
@lcawl lcawl deleted the case-file-attachments branch May 9, 2023 14:25
mergify bot pushed a commit that referenced this pull request May 9, 2023
@lcawl @mergify
[DOCS] Case file attachments (#3236)
b53e39c 
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
(cherry picked from commit 49ac99b)
@mergify mergify bot mentioned this pull request May 9, 2023
Merged
lcawl added a commit that referenced this pull request May 9, 2023
@mergify @lcawl
[DOCS] Case file attachments (#3236) (#3240)
2c3fbfa 
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
(cherry picked from commit 49ac99b)

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nastasha-solomon nastasha-solomon nastasha-solomon approved these changes

Assignees
No one assigned
Labels
v8.8.0 v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lcawl @nastasha-solomon