Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alert suppression clarification #3879

Merged
merged 5 commits into from
Sep 14, 2023
Merged

Alert suppression clarification #3879

merged 5 commits into from
Sep 14, 2023

Conversation

natasha-moore-elastic
Copy link
Contributor

@natasha-moore-elastic natasha-moore-elastic commented Sep 6, 2023 •
edited
Loading

@natasha-moore-elastic natasha-moore-elastic added Team: Detections/Response Detections and Response Feature: Alerts Team: Detection Engine Priority: Medium Issues that have relevance, but aren't urgent v8.10.0 Effort: Small Issues that can be resolved quickly labels Sep 6, 2023
@natasha-moore-elastic natasha-moore-elastic self-assigned this Sep 6, 2023
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Documentation previews:

@natasha-moore-elastic natasha-moore-elastic marked this pull request as ready for review September 6, 2023 12:32
@natasha-moore-elastic natasha-moore-elastic requested review from yctercero and a team September 6, 2023 12:33
@natasha-moore-elastic
Copy link
Contributor Author

Hey @yctercero, how far back would you like us to backport this change?

nastasha-solomon
nastasha-solomon approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, overall!

docs/detections/alert-suppression.asciidoc Outdated Show resolved Hide resolved
yctercero
yctercero approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@yctercero yctercero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the update! Just a super minor comment.

@natasha-moore-elastic
Copy link
Contributor Author

Thanks, both! @yctercero, how far back would you like us to backport this change?

@yctercero
Copy link
Contributor

Thanks, both! @yctercero, how far back would you like us to backport this change?

Looks like it was released in 8.6 - elastic/kibana#142686 .

cc @marshallmain can you confirm this should go back to when it was released in 8.6?

@marshallmain
Copy link
Contributor

cc @marshallmain can you confirm this should go back to when it was released in 8.6?

Yes, I would backport it back through 8.6.

joepeeples
joepeeples approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@natasha-moore-elastic natasha-moore-elastic merged commit 16b6c65 into main Sep 14, 2023
1 check passed
@natasha-moore-elastic natasha-moore-elastic deleted the issue-3791-alert-suppression-clarification branch September 14, 2023 09:46
mergify bot pushed a commit that referenced this pull request Sep 14, 2023
@natasha-moore-elastic @mergify
Alert suppression clarification (#3879)
34da2a7 
* Alert suppression clarification

* Review updates

* Updates note phrasing

(cherry picked from commit 16b6c65)
@mergify mergify bot mentioned this pull request Sep 14, 2023
Merged
mergify bot pushed a commit that referenced this pull request Sep 14, 2023
@natasha-moore-elastic @mergify
Alert suppression clarification (#3879)
dea1dd4 
* Alert suppression clarification

* Review updates

* Updates note phrasing

(cherry picked from commit 16b6c65)
mergify bot pushed a commit that referenced this pull request Sep 14, 2023
@natasha-moore-elastic @mergify
Alert suppression clarification (#3879)
d87747b 
* Alert suppression clarification

* Review updates

* Updates note phrasing

(cherry picked from commit 16b6c65)
This was referenced Sep 14, 2023
Merged
Merged
mergify bot pushed a commit that referenced this pull request Sep 14, 2023
@natasha-moore-elastic @mergify
Alert suppression clarification (#3879)
a51cda5 
* Alert suppression clarification

* Review updates

* Updates note phrasing

(cherry picked from commit 16b6c65)
@mergify mergify bot mentioned this pull request Sep 14, 2023
Merged
mergify bot pushed a commit that referenced this pull request Sep 14, 2023
@natasha-moore-elastic @mergify
Alert suppression clarification (#3879)
e95e3ab 
* Alert suppression clarification

* Review updates

* Updates note phrasing

(cherry picked from commit 16b6c65)

# Conflicts:
#	docs/detections/alert-suppression.asciidoc
#	docs/detections/rules-ui-create.asciidoc
@mergify mergify bot mentioned this pull request Sep 14, 2023
Merged
natasha-moore-elastic added a commit that referenced this pull request Sep 14, 2023
@mergify @natasha-moore-elastic
Alert suppression clarification (#3879) (#3947)
572fb02 
* Alert suppression clarification

* Review updates

* Updates note phrasing

(cherry picked from commit 16b6c65)

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
natasha-moore-elastic added a commit that referenced this pull request Sep 14, 2023
@mergify @natasha-moore-elastic
Alert suppression clarification (#3879) (#3948)
46c3387 
* Alert suppression clarification

* Review updates

* Updates note phrasing

(cherry picked from commit 16b6c65)

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
natasha-moore-elastic added a commit that referenced this pull request Sep 14, 2023
@mergify @natasha-moore-elastic
Alert suppression clarification (#3879) (#3949)
0f3f32d 
* Alert suppression clarification

* Review updates

* Updates note phrasing

(cherry picked from commit 16b6c65)

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
natasha-moore-elastic added a commit that referenced this pull request Sep 14, 2023
@mergify @natasha-moore-elastic
Alert suppression clarification (#3879) (#3950)
ccd6ffc 
* Alert suppression clarification

* Review updates

* Updates note phrasing

(cherry picked from commit 16b6c65)

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
natasha-moore-elastic added a commit that referenced this pull request Sep 14, 2023
@mergify @natasha-moore-elastic
[8.6] Alert suppression clarification (backport #3879) (#3951)
fd8b919 
* Alert suppression clarification (#3879)

* Alert suppression clarification

* Review updates

* Updates note phrasing

(cherry picked from commit 16b6c65)

# Conflicts:
#	docs/detections/alert-suppression.asciidoc
#	docs/detections/rules-ui-create.asciidoc

* Resolves conflicts

---------

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
Co-authored-by: natasha-moore-elastic <natasha.moore@elastic.co>
joepeeples added a commit that referenced this pull request May 22, 2024
@joepeeples
Post-8.10 mini-refresh (#143)
9ff95b2 
* Add alert suppression clarification note

Per /pull/3879

* Clarify note in new terms rule create

Per /pull/3943

* Update images for QA bugs

Per /pull/3946

* Add new terms rule type to create rule API docs

Per /pull/3914

* Add new terms rule type to *update* rule API docs

Per /pull/3914
acorretti pushed a commit that referenced this pull request Nov 19, 2024
@mergify @natasha-moore-elastic
[8.6] Alert suppression clarification (backport #3879) (#3951)
05a9be6 
* Alert suppression clarification (#3879)

* Alert suppression clarification

* Review updates

* Updates note phrasing

(cherry picked from commit 5baa89b)

# Conflicts:
#	docs/detections/alert-suppression.asciidoc
#	docs/detections/rules-ui-create.asciidoc

* Resolves conflicts

---------

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
Co-authored-by: natasha-moore-elastic <natasha.moore@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nastasha-solomon nastasha-solomon nastasha-solomon approved these changes

@joepeeples joepeeples joepeeples approved these changes

@yctercero yctercero yctercero approved these changes

Assignees

@natasha-moore-elastic natasha-moore-elastic

Labels
Effort: Small Issues that can be resolved quickly Feature: Alerts Priority: Medium Issues that have relevance, but aren't urgent Team: Detection Engine Team: Detections/Response Detections and Response v8.6.0 v8.7.0 v8.8.0 v8.9.0 v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DE] - Add alert suppression clarification for array values
5 participants
@natasha-moore-elastic @yctercero @marshallmain @nastasha-solomon @joepeeples