-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates warning about editing rules using API authentication #4110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natasha-moore-elastic
added
Team: Detections/Response
Detections and Response
API
Feature: Rules
Priority: Medium
Issues that have relevance, but aren't urgent
Effort: Small
Issues that can be resolved quickly
v8.11.0
labels
Oct 27, 2023
Documentation previews: |
benironside
reviewed
Oct 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple minor suggestions. If you incorporate the "will be" -> "gets" suggestion, it applies to the other WARNING messages as well. Thanks!
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
nastasha-solomon
approved these changes
Oct 31, 2023
yctercero
reviewed
Oct 31, 2023
This was referenced Nov 1, 2023
mergify bot
pushed a commit
that referenced
this pull request
Nov 1, 2023
* Updates warning about editing rules using API authentication * Apply suggestions from TW review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Applies TW feedback * Updates notes to address both scenarios * Removes extra period --------- Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> (cherry picked from commit 783ce5a) # Conflicts: # docs/detections/api/rules/rules-api-create.asciidoc
mergify bot
pushed a commit
that referenced
this pull request
Nov 1, 2023
* Updates warning about editing rules using API authentication * Apply suggestions from TW review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Applies TW feedback * Updates notes to address both scenarios * Removes extra period --------- Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> (cherry picked from commit 783ce5a) # Conflicts: # docs/detections/api/rules/rules-api-create.asciidoc
mergify bot
pushed a commit
that referenced
this pull request
Nov 1, 2023
* Updates warning about editing rules using API authentication * Apply suggestions from TW review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Applies TW feedback * Updates notes to address both scenarios * Removes extra period --------- Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> (cherry picked from commit 783ce5a) # Conflicts: # docs/detections/api/rules/rules-api-create.asciidoc
This was referenced Nov 1, 2023
mergify bot
pushed a commit
that referenced
this pull request
Nov 1, 2023
* Updates warning about editing rules using API authentication * Apply suggestions from TW review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Applies TW feedback * Updates notes to address both scenarios * Removes extra period --------- Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> (cherry picked from commit 783ce5a) # Conflicts: # docs/detections/api/rules/rules-api-create.asciidoc # docs/detections/api/rules/rules-api-import.asciidoc
mergify bot
pushed a commit
that referenced
this pull request
Nov 1, 2023
* Updates warning about editing rules using API authentication * Apply suggestions from TW review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Applies TW feedback * Updates notes to address both scenarios * Removes extra period --------- Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> (cherry picked from commit 783ce5a) # Conflicts: # docs/detections/api/rules/rules-api-bulk-actions.asciidoc # docs/detections/api/rules/rules-api-create.asciidoc # docs/detections/api/rules/rules-api-import.asciidoc
mergify bot
pushed a commit
that referenced
this pull request
Nov 1, 2023
* Updates warning about editing rules using API authentication * Apply suggestions from TW review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Applies TW feedback * Updates notes to address both scenarios * Removes extra period --------- Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> (cherry picked from commit 783ce5a) # Conflicts: # docs/detections/api/rules/rules-api-bulk-actions.asciidoc # docs/detections/api/rules/rules-api-create.asciidoc # docs/detections/api/rules/rules-api-import.asciidoc
This was referenced Nov 1, 2023
natasha-moore-elastic
added a commit
that referenced
this pull request
Nov 1, 2023
…4150) * Updates warning about editing rules using API authentication * Apply suggestions from TW review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Applies TW feedback * Updates notes to address both scenarios * Removes extra period --------- Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> (cherry picked from commit 783ce5a) Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
natasha-moore-elastic
added a commit
that referenced
this pull request
Nov 1, 2023
…4151) * Updates warning about editing rules using API authentication * Apply suggestions from TW review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Applies TW feedback * Updates notes to address both scenarios * Removes extra period --------- Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> (cherry picked from commit 783ce5a) Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
natasha-moore-elastic
added a commit
that referenced
this pull request
Nov 1, 2023
…4152) * Updates warning about editing rules using API authentication * Apply suggestions from TW review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Applies TW feedback * Updates notes to address both scenarios * Removes extra period --------- Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> (cherry picked from commit 783ce5a) Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
natasha-moore-elastic
added a commit
that referenced
this pull request
Nov 1, 2023
…ackport #4110) (#4153) * Updates warning about editing rules using API authentication (#4110) * Updates warning about editing rules using API authentication * Apply suggestions from TW review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Applies TW feedback * Updates notes to address both scenarios * Removes extra period --------- Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> (cherry picked from commit 783ce5a) # Conflicts: # docs/detections/api/rules/rules-api-create.asciidoc * Resolves conflict --------- Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com> Co-authored-by: natasha-moore-elastic <natasha.moore@elastic.co>
natasha-moore-elastic
added a commit
that referenced
this pull request
Nov 1, 2023
…ackport #4110) (#4154) * Updates warning about editing rules using API authentication (#4110) * Updates warning about editing rules using API authentication * Apply suggestions from TW review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Applies TW feedback * Updates notes to address both scenarios * Removes extra period --------- Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> (cherry picked from commit 783ce5a) # Conflicts: # docs/detections/api/rules/rules-api-create.asciidoc * Resolves conflict --------- Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com> Co-authored-by: natasha-moore-elastic <natasha.moore@elastic.co>
natasha-moore-elastic
added a commit
that referenced
this pull request
Nov 1, 2023
…ackport #4110) (#4155) * Updates warning about editing rules using API authentication (#4110) * Updates warning about editing rules using API authentication * Apply suggestions from TW review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Applies TW feedback * Updates notes to address both scenarios * Removes extra period --------- Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> (cherry picked from commit 783ce5a) # Conflicts: # docs/detections/api/rules/rules-api-create.asciidoc * Resolves conflict * Removes frontmatter --------- Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com> Co-authored-by: natasha-moore-elastic <natasha.moore@elastic.co>
natasha-moore-elastic
added a commit
that referenced
this pull request
Nov 1, 2023
…ackport #4110) (#4156) * Updates warning about editing rules using API authentication (#4110) * Updates warning about editing rules using API authentication * Apply suggestions from TW review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Applies TW feedback * Updates notes to address both scenarios * Removes extra period --------- Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> (cherry picked from commit 783ce5a) # Conflicts: # docs/detections/api/rules/rules-api-create.asciidoc * Resolves conflict * Removes frontmatter --------- Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com> Co-authored-by: natasha-moore-elastic <natasha.moore@elastic.co>
natasha-moore-elastic
added a commit
that referenced
this pull request
Nov 1, 2023
…ackport #4110) (#4158) * Updates warning about editing rules using API authentication (#4110) * Updates warning about editing rules using API authentication * Apply suggestions from TW review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Applies TW feedback * Updates notes to address both scenarios * Removes extra period --------- Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> (cherry picked from commit 783ce5a) # Conflicts: # docs/detections/api/rules/rules-api-create.asciidoc * Resolves conflict * Removes frontmatter --------- Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com> Co-authored-by: natasha-moore-elastic <natasha.moore@elastic.co>
natasha-moore-elastic
added a commit
that referenced
this pull request
Nov 1, 2023
…ackport #4110) (#4157) * Updates warning about editing rules using API authentication (#4110) * Updates warning about editing rules using API authentication * Apply suggestions from TW review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Applies TW feedback * Updates notes to address both scenarios * Removes extra period --------- Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> (cherry picked from commit 783ce5a) # Conflicts: # docs/detections/api/rules/rules-api-create.asciidoc * Resolves conflict * Removes frontmatter --------- Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com> Co-authored-by: natasha-moore-elastic <natasha.moore@elastic.co>
natasha-moore-elastic
added a commit
that referenced
this pull request
Nov 1, 2023
…ackport #4110) (#4159) * Updates warning about editing rules using API authentication (#4110) * Updates warning about editing rules using API authentication * Apply suggestions from TW review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Applies TW feedback * Updates notes to address both scenarios * Removes extra period --------- Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> (cherry picked from commit 783ce5a) # Conflicts: # docs/detections/api/rules/rules-api-create.asciidoc # docs/detections/api/rules/rules-api-import.asciidoc * Resolves conflict * Removes frontmatter --------- Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com> Co-authored-by: natasha-moore-elastic <natasha.moore@elastic.co>
natasha-moore-elastic
added a commit
that referenced
this pull request
Nov 1, 2023
…ackport #4110) (#4160) * Updates warning about editing rules using API authentication (#4110) * Updates warning about editing rules using API authentication * Apply suggestions from TW review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Applies TW feedback * Updates notes to address both scenarios * Removes extra period --------- Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> (cherry picked from commit 783ce5a) # Conflicts: # docs/detections/api/rules/rules-api-bulk-actions.asciidoc # docs/detections/api/rules/rules-api-create.asciidoc # docs/detections/api/rules/rules-api-import.asciidoc * Resolves conflict * Removes deprecation note * Removes frontmatter --------- Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com> Co-authored-by: natasha-moore-elastic <natasha.moore@elastic.co>
natasha-moore-elastic
added a commit
that referenced
this pull request
Nov 1, 2023
…ackport #4110) (#4161) * Updates warning about editing rules using API authentication (#4110) * Updates warning about editing rules using API authentication * Apply suggestions from TW review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Applies TW feedback * Updates notes to address both scenarios * Removes extra period --------- Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> (cherry picked from commit 783ce5a) # Conflicts: # docs/detections/api/rules/rules-api-bulk-actions.asciidoc # docs/detections/api/rules/rules-api-create.asciidoc # docs/detections/api/rules/rules-api-import.asciidoc * Resolves conflict * Removes frontmatter --------- Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com> Co-authored-by: natasha-moore-elastic <natasha.moore@elastic.co>
acorretti
pushed a commit
that referenced
this pull request
Nov 19, 2024
…ackport #4110) (#4158) * Updates warning about editing rules using API authentication (#4110) * Updates warning about editing rules using API authentication * Apply suggestions from TW review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Applies TW feedback * Updates notes to address both scenarios * Removes extra period --------- Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> (cherry picked from commit 0c55d76) # Conflicts: # docs/detections/api/rules/rules-api-create.asciidoc * Resolves conflict * Removes frontmatter --------- Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com> Co-authored-by: natasha-moore-elastic <natasha.moore@elastic.co>
acorretti
pushed a commit
that referenced
this pull request
Nov 19, 2024
…ackport #4110) (#4161) * Updates warning about editing rules using API authentication (#4110) * Updates warning about editing rules using API authentication * Apply suggestions from TW review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Applies TW feedback * Updates notes to address both scenarios * Removes extra period --------- Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> (cherry picked from commit 0c55d76) # Conflicts: # docs/detections/api/rules/rules-api-bulk-actions.asciidoc # docs/detections/api/rules/rules-api-create.asciidoc # docs/detections/api/rules/rules-api-import.asciidoc * Resolves conflict * Removes frontmatter --------- Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com> Co-authored-by: natasha-moore-elastic <natasha.moore@elastic.co>
acorretti
pushed a commit
that referenced
this pull request
Nov 19, 2024
…ackport #4110) (#4154) * Updates warning about editing rules using API authentication (#4110) * Updates warning about editing rules using API authentication * Apply suggestions from TW review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Applies TW feedback * Updates notes to address both scenarios * Removes extra period --------- Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> (cherry picked from commit 0c55d76) # Conflicts: # docs/detections/api/rules/rules-api-create.asciidoc * Resolves conflict --------- Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com> Co-authored-by: natasha-moore-elastic <natasha.moore@elastic.co>
acorretti
pushed a commit
that referenced
this pull request
Nov 19, 2024
…ackport #4110) (#4155) * Updates warning about editing rules using API authentication (#4110) * Updates warning about editing rules using API authentication * Apply suggestions from TW review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Applies TW feedback * Updates notes to address both scenarios * Removes extra period --------- Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> (cherry picked from commit 0c55d76) # Conflicts: # docs/detections/api/rules/rules-api-create.asciidoc * Resolves conflict * Removes frontmatter --------- Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com> Co-authored-by: natasha-moore-elastic <natasha.moore@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
API
Effort: Small
Issues that can be resolved quickly
Feature: Rules
Priority: Medium
Issues that have relevance, but aren't urgent
Team: Detections/Response
Detections and Response
v8.0.0
v8.1.0
v8.2.0
v8.3.0
v8.4.0
v8.5.0
v8.6.0
v8.7.0
v8.8.0
v8.9.0
v8.10.0
v8.11.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previews: