-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Azure eventhub support #58
Conversation
3b42c78
to
be149db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At a quick glance, the main parts that I noticed is that since we don't emulate eventhub locally or in docker in any way, we need to add some more credential options.
Usually the Connection String or some sort of credentials file option would be great, and default back (with a log entry) when no credentials are found, that its going to use default or environment variable instead.
Check the golangci-lint output as well :)
It looks nice! I wonder if we could add some tests for it if possible and to add some docs about how to use it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs docs and probably at least one example configuration to help users understand how to hold it.
9beac38
to
89744e8
Compare
Raised Azure/azure-sdk-for-go#21758 for adding support for emulator in Azurite for Event Hub. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add support for Azure eventhub output.
For Credentials : https://github.com/Azure/azure-sdk-for-go/blob/6b6f76ebe0d2334c83e8b6f89af4fe9d0b1ce631/sdk/azidentity/README.md?plain=1#L156-L187
Test Execution
Screenshots
Messages in Azure portal