Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automation - add changelog and release automation #86

Merged
merged 5 commits into from
Apr 3, 2024

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Mar 22, 2024

Add a new Github workflow for releases that automates the generation of a draft GH release with changelog notes.

Pull requests will be required to add new file to at .changelog/<pr_number>.txt with a changelog message or label with skip-changelog to bypass the check. See CONTRIBUTING.md for more details.

This backfills the .changelog directory with entries for changes since v0.14.0.

(I cloned this from go-sysinfo.)

Add a new Github workflow for releases that automates
the generation of a draft GH release with changelog notes.

Pull requests will be required to add new file to at
.changelog/<pr_number>.txt with a changelog message or
label with skip-changelog to bypass the check. See
CONTRIBUTING.md for more details.

This backfills the .changelog directory with entries
for changes since v0.14.0.
@andrewkroh andrewkroh added the skip-changelog The change does not require a changelog entry. label Mar 22, 2024
@andrewkroh andrewkroh marked this pull request as ready for review March 22, 2024 22:02
@andrewkroh andrewkroh requested review from a team March 22, 2024 22:02
CONTRIBUTING.md Outdated
- Include a [changelog][changelog_docs] entry at `.changelog/{pr-number}.txt` with your pull request.
- Include tests that demonstrate the change is working.

[changelog_docs]: https://github.com/GoogleCloudPlatform/magic-modules/blob/2834761fec3acbf35cacbffe100530f82eada650/.ci/RELEASE_NOTES_GUIDE.md#expected-format
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this line at all on the rendered github view: https://github.com/andrewkroh/stream/blob/release-workflow/CONTRIBUTING.md

But maybe there could be a template or examples of the format in this repo. I don't find the linked page very clear. Should there be a PR description before the release note? From the changelog in this PR, I guess not, but the doc makes it seem like it should.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added more explanation and examples in the CONTRIBUTING.md. After a few changes are made there will be many examples to follow in the .changelog/ dir.

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems a shame to lose the old change log info (I know it's in the releases page — this is not committed).

@andrewkroh
Copy link
Member Author

It seems a shame to lose the old change log info (I know it's in the releases page — this is not committed).

I could move it to something like .changelog/.pre-0.15.0-changelog.md?

@efd6
Copy link
Contributor

efd6 commented Apr 3, 2024

That SGTM

@elasticmachine
Copy link

💚 Build Succeeded

History

@andrewkroh andrewkroh merged commit 11a55b9 into elastic:main Apr 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog The change does not require a changelog entry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants