Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix[pcap]: check for nil packet and transport layer #88

Merged
merged 2 commits into from
Apr 1, 2024
Merged

fix[pcap]: check for nil packet and transport layer #88

merged 2 commits into from
Apr 1, 2024

Conversation

pkoutsovasilis
Copy link
Contributor

@pkoutsovasilis pkoutsovasilis commented Apr 1, 2024 •
edited
Loading

While streaming a pcap file I stumbled upon a nil pointer access panic. This PR fixes that case

andrewkroh
andrewkroh approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please add a line to the CHANGELOG.md file.

@elasticmachine
Copy link

💚 Build Succeeded

History

@pkoutsovasilis pkoutsovasilis merged commit 69177af into elastic:main Apr 1, 2024
7 checks passed
@pkoutsovasilis pkoutsovasilis deleted the fix_nil_transport_pcap branch April 1, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pkoutsovasilis @elasticmachine @andrewkroh