Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use pull-request event for PR title linting #967

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

v1v
Copy link
Member

@v1v v1v commented Oct 17, 2024

We enabled this to validate the PR listing in the title always.

However, I cannot think of what's the reason we cannot protect ourselves and use Require approval for all outside collaborators as we do in the other workflows.

Any genuine reasons, we need to run always regardless the code is not tested until the PR has been approved?

@v1v v1v changed the title github-actions: use pull-request event ci: use pull-request event Oct 17, 2024
Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should be good to run this workflow after the approval.

@v1v v1v requested a review from a team October 17, 2024 15:43
@v1v v1v merged commit a7b8f7f into main Oct 17, 2024
9 checks passed
@v1v v1v deleted the feature/use-pr-lint-pr-instead branch October 17, 2024 15:47
@v1v v1v changed the title ci: use pull-request event ci: use pull-request event for PR title linting Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants