fix: adding warning when pushing monitors from yaml files #977
Conversation
|
💚 CLA has been signed |
I've since signed the agreement. Let me know if you need anything else here. |
vigneshshanmugam
changed the title
|
@Spoonsk Thank you for the contribution :) |
|
@Spoonsk Can you sign the CLA again? Thanks. |
I filled out the CLA again with my github name and we are still seeing the CLA failure. Is there something we need to do to retrigger the CLA evaluation? |
|
@Spoonsk i see commits from 2 users names, Joe Gast and you, maybe Joe Gast also need to sign? |
I just signed. |
|
I see the issue. We have some commits on here that were created by a user with an email that isn't associated with a github account. I will try to re-author those commits on this Branch, if that doesn't work. Then I may need to create another branch with another PR and we can abandon this one. |
- Validation/warning prior to UTF-8 decoding of files - warning when a 'browser' type monitor is ignored - removing unused variable (causing linter error)
changing warning text Co-authored-by: Vignesh Shanmugam <vignesh.shanmugam22@gmail.com>
…ding - updated types@node to be more in line with current version
Co-authored-by: Vignesh Shanmugam <vignesh.shanmugam22@gmail.com>
Spoonsk
force-pushed
the
adding-warnings-to-npx-push
branch
from
87d34bc
to
74933d0
Compare
|
There we go. I was able to re-author the Joe Gast commits. Should CLA should be happy now. |
Added warnings to npx push for scenarios where monitors are silently ignored. See Add warnings for silent failures during lightweight synthetics pushes #976