Handle unknown values in deployment snapshot repository references #666
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the code was setting
repository.reference: null
in state for ESS deployments. This means thatUseStateForUnknown
does not actually set the planned value, leaving it as unknown. When TF comes back to parse this into theElasticsearchSnapshotRepositoryReference
struct it can't and the whole thing falls apart.This PR updates the code to only set the repository reference value if it exists. In reality this just moves the problem up one level to the
repository
field, but we introduce a TF type where the repository support unknowns viatypes.Object
, updating the consuming code accordingly.Related Issues
Fixes #665
Motivation and Context
How Has This Been Tested?
Manually, I don't understand why this wasn't failing the existing acceptance tests. I'm clearly missing something, as I would have expected any updates to hit this error (that's my manual repro).
Types of Changes
Readiness Checklist