Persist snapshot source in the read response #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will look at adding some unit tests here too |
|
Acceptance tests failed due to the flaky test with Integration server endpoints. |
tobio
added a commit
to tobio/terraform-provider-ec
that referenced
this pull request
Mar 11, 2024
…ployment-id-with-self * upstream/master: Persist snapshot source in the read response (elastic#788) Stateless resources require kibana (elastic#792) Fixed error when universal profiling is activated (elastic#783) fix(deps): update module github.com/hashicorp/terraform-plugin-framework to v1.6.0 (elastic#790)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the
snapshot_nameis computed we must persist it in the response from read. This PR ensures that any configured value is maintained through the read cycle.Related Issues
Fixes #787
How Has This Been Tested?
Manually
Types of Changes
Readiness Checklist