Automatically add and remove dedicated masters. #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigerdo
force-pushed
the
automatic-dedicated-masters
branch
2 times, most recently
from
93b0677 to
f8f7fb2
Compare
If no master tier is configured, it is automatically added/removed: - Added if the number of nodes is >= the dedicated master threshold - Removed if the number of nodes is < the dedicated master threshold If the TF config already contains a master tier, the plan-modifier is skipped.
gigerdo
force-pushed
the
automatic-dedicated-masters
branch
from
ed50d36 to
10861ec
Compare
gigerdo
force-pushed
the
automatic-dedicated-masters
branch
from
d4ad4cc to
bb68f78
Compare
tobio
reviewed
May 2, 2024
ec/ecresource/deploymentresource/planmodifiers/topology_dedicated_masters.go
Outdated
Show resolved
Hide resolved
ec/ecresource/deploymentresource/planmodifiers/topology_dedicated_masters.go
Outdated
Show resolved
Hide resolved
ec/ecresource/deploymentresource/planmodifiers/topology_dedicated_masters.go
Outdated
Show resolved
Hide resolved
ec/ecresource/deploymentresource/planmodifiers/topology_dedicated_masters.go
Outdated
Show resolved
Hide resolved
ec/ecresource/deploymentresource/planmodifiers/topology_dedicated_masters.go
Outdated
Show resolved
Hide resolved
This happens if a tier requests more memory than the largest size available. In this case multiple nodes are provisioned.
|
@tobio thank you for the feedback. I implemented your feedback in the last two commits. |
dimuon
reviewed
May 2, 2024
ec/ecresource/deploymentresource/planmodifiers/topology_dedicated_masters.go
Outdated
Show resolved
Hide resolved
dimuon
reviewed
May 2, 2024
ec/ecresource/deploymentresource/planmodifiers/topology_dedicated_masters.go
Outdated
Show resolved
Hide resolved
dimuon
reviewed
May 2, 2024
ec/ecresource/deploymentresource/planmodifiers/topology_dedicated_masters.go
Outdated
Show resolved
Hide resolved
dimuon
reviewed
May 2, 2024
dimuon
reviewed
May 2, 2024
dimuon
reviewed
May 3, 2024
It is important to use UseTopologyStateForUnknown here, as UseStateForUnknown will also set a state for all children of the topology. However the children should stay unknown and their plan modifiers don't run. This leads to problems when migrating templates, as the master tier should then not use the state and instead get the new values from the new template.
- The IC should only be updated if 'migrate_to_latest_hardware' is set - When this is set -> Take the latest values from deployment-template - The master tier should only be updated in the plan if it actually is being enabled or disabled - When the master tier has a ic-id and ic-version, those should be used to decide the default size and zone-count - However the deployment-template will always contain the latest version, which may not be the one used in the tier currently - So now the plan-modifier will load the correct IC via API and then use that
dimuon
reviewed
May 17, 2024
dimuon
reviewed
May 17, 2024
dimuon
reviewed
May 17, 2024
dimuon
reviewed
May 17, 2024
dimuon
reviewed
May 17, 2024
- Use template if migrateToLatestHw==true - Try using IC from private state - Fall back to template if no IC in private state (for example during create)
|
@dimuon thank you very much for taking the time to review this 🥇 |
|
Hello @gigerdo , any timeline to when this will be released ? |
|
@hnajib-sym we do have plans to release a version 0.11 soon, though we don't have an exact timeline. |
|
We also have run into this same issue and would love to see a release soon! |
Merged
|
We have now release 0.11.0 which contains this feature: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the terraform config defines no master, the provider will add/remove it as needed:
Regarding the implementation:
ModifyPlanmodifier to first calculate the number of nodes, then adds or removes the master tierRelated Issues
#635
(Most of the problems described in that issue have already been solved, this PR just adds automatically adding/removing master tier)
Motivation and Context
How Has This Been Tested?
Types of Changes
Readiness Checklist