apps sc: dex upgraded to app version 2.40.0 and chart version 0.18.0

[viktor-f]

Warning

This is a public repository, ensure not to disclose:

• personal data beyond what is necessary for interacting with this pull request, nor
• business confidential information, such as customer names.

What kind of PR is this?

Required: Mark one of the following that is applicable:

• kind/feature
• kind/improvement
• kind/deprecation
• kind/documentation
• kind/clean-up
• kind/bug
• kind/other

Optional: Mark one or more of the following that are applicable:

Important

Breaking changes should be marked kind/admin-change or kind/dev-change depending on type
Critical security fixes should be marked with kind/security

• kind/admin-change
• kind/dev-change
• kind/security
• kind/adr

What does this PR do / why do we need this PR?

This upgrades dex to app version 2.40.0 and chart version 0.18.0

The google connector config adminEmail: <email> has been deprecated in favor of domainToAdminEmail. '*': <email>. It is now possible to have different admin emails for different domains, see the upstream PR for more details: dexidp/dex#2911

• Fixes [2] Upgrade dex chart #2024

Information to reviewers

There might be a better way to update the config. The way I have here seems to delete any comments present in the secrets.yaml file. Suggestions are very welcome.

I forgot to update the config schema, will do that soon.

Checklist

• Proper commit message prefix on all commits
• Change checks:
  • The change is transparent
  • The change is disruptive
  • The change requires no migration steps
  • The change requires migration steps
  • The change upgrades CRDs
  • The change updates the config and the schema
• Metrics checks:
  • The metrics are still exposed and present in Grafana after the change
  • The metrics names didn't change (Grafana dashboards and Prometheus alerts are not affected)
  • The metrics names did change (Grafana dashboards and Prometheus alerts were fixed)
• Logs checks:
  • The logs do not show any errors after the change
• Pod Security Policy checks:
  • Any changed pod is covered by Pod Security Admission
  • Any changed pod is covered by Gatekeeper Pod Security Policies
  • The change does not cause any pods to be blocked by Pod Security Admission or Policies
• Network Policy checks:
  • Any changed pod is covered by Network Policies
  • The change does not cause any dropped packets in the NetworkPolicy Dashboard
• Audit checks:
  • The change does not cause any unnecessary Kubernetes audit events
  • The change requires changes to Kubernetes audit policy
• Falco checks:
  • The change does not cause any alerts to be generated by Falco
• Bug checks:
  • The bug fix is covered by regression tests

[viktor-f]

As I mentioned in the description: this will remove any comments in the dex block (comments in other blocks are fine). Does that feel ok?

[Xartos]

As I mentioned in the description: this will remove any comments in the dex block (comments in other blocks are fine). Does that feel ok?

I'd say yes. You should be able to see that diff in git anyway and add it back if you feel it's important

[viktor-f]

Thanks to @Zash and @aarnq the script now does not remove the comments.