Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rmdir should produce error 'ENOTEMPTY' when a directory is not empty #3

Closed
kdvolder opened this issue Feb 21, 2013 · 3 comments
Closed

rmdir should produce error 'ENOTEMPTY' when a directory is not empty #3

kdvolder opened this issue Feb 21, 2013 · 3 comments

Comments

@kdvolder
Copy link

Right now I think it deletes the directory without producing an error.
kdvolder added a commit to kdvolder/node-fake-fs that referenced this issue Feb 22, 2013
@kdvolder
Attempt to fix eldargab#3: eldargab#3
4682293
@kdvolder kdvolder mentioned this issue Feb 22, 2013
Closed
@kdvolder
Copy link
Author

Please ignore previous fix attempt which didn't work. The pull request #4 does work. It is indirectly tested by some tests in our own codebase which use fake-fs, but I did not add any regression tests to fake-fs itself.

@eldargab
Copy link
Owner

Thanks for reporting.

@kdvolder
Copy link
Author

Thanks for fixing it so quickly, and thanks for fakefs in general. It is a very useful testing tool :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eldargab @kdvolder