Escape geoip html #69
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you make your PR "Add html escaping to geoip" into a separate PR that differs from indentation ? |
watercrossing
force-pushed
the
htmlfixes
branch
from
fa7c053
to
985ab07
Compare
|
I have rebased the original fix to the latest |
|
Should be fixed by #131 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The geoip plugin prints a number of html special characters without escaping them -
& <>. I have done the lazy fix for this and used theencode_entitiesfunction fromHTML::Entities. This fix is done in 7e53176.The second commit is entirely style - the two geoip plugin files have no discernible style at all, so i have applied some standard formatting. I did not find any guidance on the formatting for awstats, but I will re-format if you let me know.