Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update version and handle multiple post_ids correctly #1150

Merged
merged 2 commits into from
Aug 12, 2022
Merged

update version and handle multiple post_ids correctly #1150

merged 2 commits into from
Aug 12, 2022

Conversation

swoker
Copy link
Contributor

@swoker swoker commented Aug 11, 2022

Description

  1. Version in develop is too low, so we get a warning message every time right now :D
  2. if I have multiple post_ids set in config.toml, the script will currently run times_to_run-times, ignoring the post_id. Instead it should run every post_id and finish afterwards, ignoring times_to_run .

Checklist:

  • I am pushing changes to the develop branch
  • I am using the recommended development environment
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have formatted and linted my code using python-black and pylint
  • I have cleaned up unnecessary files
  • My changes generate no new warnings
  • My changes follow the existing code-style
  • My changes are relevant to the project

@JasonLovesDoggo
Copy link
Collaborator

Nice catch!

@JasonLovesDoggo JasonLovesDoggo merged commit 1189f84 into elebumm:develop Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants