Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added more functions to GUI #1211

Merged
merged 1 commit into from
Aug 27, 2022
Merged

Added more functions to GUI #1211

merged 1 commit into from
Aug 27, 2022

Conversation

rivenintech
Copy link
Contributor

@rivenintech rivenintech commented Aug 25, 2022 •
edited
Loading

Changes

  • Access to settings (config.toml) through GUI
  • Adding/removing backgrounds through GUI
  • Testing TTS voices through GUI (my favourite)
  • Dynamic validation

image

image

image

Checklist:

  • I am pushing changes to the develop branch
  • I am using the recommended development environment
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have formatted and linted my code using python-black and pylint
  • I have cleaned up unnecessary files
  • My changes generate no new warnings
  • My changes follow the existing code-style
  • My changes are relevant to the project

Any other information (e.g how to test the changes)

Any feedback is really appreciated! 🚀

@rivenintech
Added more functions to GUI
9cd94da 
- Access to settings (config.toml) through GUI
- Adding/removing backgrounds through GUI
- Testing TTS voices through GUI
@JasonLovesDoggo
Copy link
Collaborator

Looks amazing but keep in mind of #1207

JasonLovesDoggo
JasonLovesDoggo requested changes Aug 27, 2022
View reviewed changes
Copy link
Collaborator

@JasonLovesDoggo JasonLovesDoggo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except with that one tiny thing

utils/.config.template.toml Show resolved Hide resolved
@JasonLovesDoggo JasonLovesDoggo merged commit 8ddc4b2 into elebumm:develop Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonLovesDoggo JasonLovesDoggo JasonLovesDoggo requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rivenintech @JasonLovesDoggo