-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the story mode with 2 methods and add min comment lenght #1288
Conversation
I have solve conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, but I have a couple of questions. Also, this needs to be tested
refactor:acess browser less duration of brower usage
Try using https://moviepy-tburrows13.readthedocs.io/en/latest/_modules/moviepy/video/fx/scroll.html Instead of multiple screenshots |
yes possible it looks more like comment mode that's why I choose this approach |
When will this be released? Or How can I at least get the beta version of this to be working? |
Hey, I hope we can release this soon. But it needs to be tested a lot because it's a big feature. I would recommend to join Lewis' Discord server, more information about testing the story mode is there! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR! Can you fix the things I reviewed? Then I'll finally merge
Added the story mode with two options! The first option is only a screenshot of the post description (looks ugly with long posts). The second option generates images for every sentence.
I also added minimum comment length sorting feature
Checklist:
Any other information (e.g how to test the changes)
It's a big feature and it needs to be tested a lot.