-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: header and parameter names. #1900
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for electric-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
343b52c
to
1d0ed6f
Compare
Btw, I don't understand why the typecheck tests are failing.
|
@thruflo the |
Yup, I've I'm not really the right person to revise the way we run our CI tests :) |
@thruflo I was also seeing the same issue - typecheck passed locally but failed on CI, and the lines referenced on CI for the errors did not match the actual test file, so something odd happening there... There's a conflict now so tests aren't running though. |
ba5ec88
to
8261b25
Compare
@msfstef fixed the conflict. |
@thruflo types fixed 💪 🚀 |
This is a rebase of some changes to rename:
electric-chunk-last-offset
->electric-offset
electric-next-cursor
->electric-cursor
electric-shape-handle
->electric-handle
?shape_handle
->?handle
Painfully rebased on the previous
shape_handle
and table path -> query param change in #1798).So I believe we can merge this instead of those and this will match the new documentation. I haven't yet added a changeset.