-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(electric): Allow the migrations proxy to accept WebSocket connections #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alco
force-pushed
the
alco/pg-proxy-over-websocket
branch
from
December 8, 2023 15:08
18e02cd
to
05726ee
Compare
magnetised
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
crazy stuff! horrifying and yet genius.
components/electric/lib/electric/postgres/proxy/websocket_server.ex
Outdated
Show resolved
Hide resolved
alco
force-pushed
the
alco/pg-proxy-over-websocket
branch
from
December 11, 2023 22:03
6ac89da
to
e4bca5a
Compare
alco
force-pushed
the
alco/pg-proxy-over-websocket
branch
from
December 11, 2023 22:16
7d9ecc6
to
14e29b4
Compare
alco
force-pushed
the
alco/pg-proxy-over-websocket
branch
from
December 12, 2023 09:13
14e29b4
to
118bb3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes VAX-1417.
This change makes #735 possible.