Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added exchange file for Lesotho-South Africa. #7298

Merged
merged 6 commits into from
Oct 8, 2024

Conversation

u7262835
Copy link
Contributor

@u7262835 u7262835 commented Oct 8, 2024

Issue

This pull request resolves Issue #7270 (Missing exchange configuration between South Africa (ZA) and Lesotho (LS)).

Description

This pull request adds an exchange configuration file (LS_ZA.yaml) containing the longitude, latitude, and rotation of the South Africa -> Lesotho exchange. The location of this exchange is at the Maseru border in accordance with the Southern African Power Pool grid map (https://www.sapp.co.zw/) and the Lesotho Electrification Master Plan Report (https://nul-erc.s3.amazonaws.com/public/documents/reports/lesotho-electrification-master-plan-grid-1532184999.pdf, pg. 9).

No capacity information (or live, parse-able data) was found for this exchange. I will continue to search for this, and update it in a new pull request if found (however this seems unlikely for the near future, as the only free information found to date was static and outdated).

Preview

There are no applicable preview screenshots. The LS_ZA.yaml file should be reviewed by a maintainer/experienced ElectricityMaps developer for correctness before accepting the merge to confirm that it will create an exchange at an appropriate location (@VIKTORVAV99 suggested that he can do this: #7270 (comment))).

Double check

  • I have tested my parser changes locally with poetry run test_parser "zone_key" (N/A)
  • I have run pnpx prettier@2 --write . and poetry run format in the top level directory to format my changes. (N/A)

@github-actions github-actions bot added the exchange config Pull request or issue for exchange configurations label Oct 8, 2024
@u7262835
Copy link
Contributor Author

u7262835 commented Oct 8, 2024

@VIKTORVAV99 requesting a review regarding Issue #7270.

@VIKTORVAV99 VIKTORVAV99 self-requested a review October 8, 2024 11:58
u7262835 and others added 3 commits October 9, 2024 07:13
Changed rotation to comply with exchange format (Lesotho to South Africa) after exchange flow clarifications.

Co-authored-by: Viktor Andersson <30777521+VIKTORVAV99@users.noreply.github.com>
@VIKTORVAV99 VIKTORVAV99 enabled auto-merge (squash) October 8, 2024 20:20
Copy link
Member

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

Thanks for adding it!

@VIKTORVAV99 VIKTORVAV99 merged commit ace2eb4 into electricitymaps:master Oct 8, 2024
20 checks passed
@u7262835 u7262835 deleted the ZA_LS_Config branch October 8, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exchange config Pull request or issue for exchange configurations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants