Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]AVO-592: Add Scroll-to functionality #7333

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

cadeban
Copy link
Contributor

@cadeban cadeban commented Oct 18, 2024

Description

AVO-592

Preview

Double check

  • I have tested my parser changes locally with poetry run test_parser "zone_key"
  • I have run pnpx prettier@2 --write . and poetry run format in the top level directory to format my changes.

@cadeban cadeban self-assigned this Oct 18, 2024
@cadeban cadeban changed the title [WIP][AVO-592]: Add Scroll-to functionality [WIP]AVO-592: Add Scroll-to functionality Oct 18, 2024
@@ -4,8 +4,8 @@
import LoadingSpinner from 'components/LoadingSpinner';
import BarBreakdownChart from 'features/charts/bar-breakdown/BarBreakdownChart';
import { useAtomValue, useSetAtom } from 'jotai';
import { useEffect } from 'react';
import { Navigate, useParams } from 'react-router-dom';
import { useCallback, useEffect } from 'react';

Check warning

Code scanning / ESLint

Disallow unused variables Warning

'useCallback' is defined but never used. Allowed unused vars must match /^_/u.

Copilot Autofix AI 2 days ago

To fix the problem, we need to remove the unused useCallback import from the file. This will resolve the ESLint error and clean up the code. The change is straightforward and involves deleting the useCallback import statement from the list of imports.

Suggested changeset 1
web/src/features/panels/zone/ZoneDetails.tsx

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/web/src/features/panels/zone/ZoneDetails.tsx b/web/src/features/panels/zone/ZoneDetails.tsx
--- a/web/src/features/panels/zone/ZoneDetails.tsx
+++ b/web/src/features/panels/zone/ZoneDetails.tsx
@@ -6,3 +6,3 @@
 import { useAtomValue, useSetAtom } from 'jotai';
-import { useCallback, useEffect } from 'react';
+import { useEffect } from 'react';
 import { Navigate, useLocation, useNavigate, useParams } from 'react-router-dom';
EOF
@@ -6,3 +6,3 @@
import { useAtomValue, useSetAtom } from 'jotai';
import { useCallback, useEffect } from 'react';
import { useEffect } from 'react';
import { Navigate, useLocation, useNavigate, useParams } from 'react-router-dom';
Copilot is powered by AI and may make mistakes. Always verify output.
Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant