fix(rpm-updater): stop uninstalling app before update (#8311)

Stop uninstalling an app before it updates, as dnf, yum, and zypper all support updating an app from a .rpm, and because app.getName() returns the product name of the app instead of its package name. (Fixes #8305)
electron-userland · Jul 10, 2024 · 35a0784 · 35a0784
1 parent dd145d6
commit 35a0784
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 10 deletions.
diff --git a/.changeset/real-ducks-repair.md b/.changeset/real-ducks-repair.md
@@ -0,0 +1,5 @@
+---
+"electron-updater": patch
+---
+
+fix(rpm-updater): stop uninstalling app before update
diff --git a/packages/electron-updater/src/RpmUpdater.ts b/packages/electron-updater/src/RpmUpdater.ts
@@ -36,18 +36,9 @@ export class RpmUpdater extends BaseUpdater {
     let cmd: string[]
     if (!packageManager) {
       const packageManager = this.spawnSyncLog("which dnf || which yum")
-      cmd = [packageManager, "-y", "remove", `'${this.app.name}'`, ";", packageManager, "-y", "install", upgradePath]
+      cmd = [packageManager, "-y", "install", upgradePath]
     } else {
       cmd = [
-        packageManager,
-        "remove",
-        "-y",
-        `'${this.app.name}'`,
-        ";",
-        packageManager,
-        "clean",
-        "--all",
-        ";",
         packageManager,
         "--no-refresh",
         "install",