fix: Duplicate values during deep assign of extra files (#7019)

Filters out duplicate assign's when cascading configs (files, extraFiles, etc.) by converting to Set first
electron-userland · Jul 21, 2022 · 98d3a63 · 98d3a63
1 parent 62cf003
commit 98d3a63
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/mean-cheetahs-look.md b/.changeset/mean-cheetahs-look.md
@@ -0,0 +1,5 @@
+---
+"builder-util": patch
+---
+
+fix: Filter out duplicate values during deep assign of extra files by converting to Set first
diff --git a/packages/builder-util/src/deepAssign.ts b/packages/builder-util/src/deepAssign.ts
@@ -18,7 +18,7 @@ function assignKey(target: any, from: any, key: string) {
   if (prevValue == null || value == null || !isObject(prevValue) || !isObject(value)) {
     // Merge arrays.
     if (Array.isArray(prevValue) && Array.isArray(value)) {
-      target[key] = prevValue.concat(value)
+      target[key] = Array.from(new Set(prevValue.concat(value)))
     } else {
       target[key] = value
     }