-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Electron not launching with latest sharp libraries #5438
Comments
Hi, any updates on this issue would help us understand timelines. |
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Still valid, PR with a fix to invoke prebuild-install correctly develar/app-builder#47 |
Any updates on this? |
All merged, waiting for release.
|
INFO Building app with electron-builder: To ensure your native dependencies are always matched electron version, simply add script
ExecError: /Users/lc/st/wmswarehouse/node_modules/app-builder-bin/mac/app-builder exited with code ERR_ELECTRON_BUILDER_CANNOT_EXECUTE |
I tried, but it didn't work |
Versions 22.11.1 and higher of Please report back here if those versions work for you 👍🏼 |
Preparing for the postcss update. Note: - Keytar is intentionally pinned to 7.6.0 due to an electron-builder bug that makes 7.7.0 not work. atom/node-keytar#380 electron-userland/electron-builder#5438
* Update dependencies, part 1 Preparing for the postcss update. Note: - Keytar is intentionally pinned to 7.6.0 due to an electron-builder bug that makes 7.7.0 not work. atom/node-keytar#380 electron-userland/electron-builder#5438 * Update dependencies, part 2 Mostly preparing to get rid of unsupported and vulnerable PostCSS 7. Notes: - This requires a lot of beta versions for Vue-related packages. Non-beta versions tend to depend on PostCSS 7. - PostCSS 7 is still not eliminated entirely as one of the Vue packages still requires 7. - The babel-eslint package is deprecated, but can't be upgraded to the non-deprecated @babel/eslint-parser package, otherwise the standard build process would be broken. - The change in the SVG icon component was needed to make SVG icons display again. Not sure why this happened. - It seems Electron 13 can't be used due to no support from Keytar. * Fix sorting functions in spellbook.js * Fix login form allowing to enter "new" data under existing names This silently overwrote and/or added to old settings. Now it's a validation error. * Fix saving wiki farms with certain URL patterns Closes: #67 * Adjust breakpoints in the login screen Closes: #65 * Increase vertical spacing in the login form That makes the fields much more clearly separated. Closes: #64 * Add event handlers for modals Currently just the Escape key is handled to close the modal. Closes: #63 * Update dependencies, part 3 This gets rid of the PostCSS security alert. Unfortunately, two new and unrelated vulnerabilities were reported in other indirect dependencies two days ago. Closes: #66 * Address keyboard navigation in task view modals The actual view still has some issues. * Switch to Tailwind utility and adjust the lightness slightly. This should also fit both light and dark themes (somewhat). * Improve task view navigation further Add focus indicators, fix elements that shouldn't be focusable, fix the "no input" zone of "Enabled?" checkboxes, and extract the "deferred focus" hack into its own method. Sigh. Closes: #59 * Fix logic error with deferred focusing That added one iteration to the loop = extra 50 milliseconds of waiting. Improves switching times when the conditionally-rendered element is absent from the DOM entirely (read: `v-if`). * Make the controls on the home page more separated Like with the changes to the login menu. * Improve keyboard navigation for the home view Like with the tasks view. Also de-cluttered the HTML by using `@apply` in a `<style>` rather than specifying all utilities inline. * Improve focusing indication in the login view as well * Import jquery Why didn't anyone do this before? * Implement class-based dark mode handling Simplifies style testing. Closes: #61 * Persist home view state This should actually be not just a major usability issue, but a critical matter of communicating state to other components. * Fix logic error in home view Otherwise this will print errors about accessing the `accounts` property of `undefined`. * Persist login view data * Improve inactive input visibility in dark login view * Persist task view state. This does not persist actual task process. This will have to be handled very, very differently, and I'm not sure how yet. Closes: #53 * Fix improperly using event handler
Same here like @AlanSean said. Seems like it is not working. Even with latest version electron-builder and sharp version. |
I think you're experiencing the same issue i just reported here: #6200 |
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
electron: "8.5.5",
electron-builder: "22.9.1"
Target: Ubuntu Linux
Sharp: 0.26.3
Suggestion from sharp author::
electron-builder needs to be modified, either to skip dependencies that uses N-API, or to invoke prebuild-install with runtime=napi first, then fallback to runtime=electron.
lovell/sharp#2440
The text was updated successfully, but these errors were encountered: